Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May be make search case insensitive? #6

Closed
for-coursera opened this issue Jan 13, 2020 · 6 comments
Closed

May be make search case insensitive? #6

for-coursera opened this issue Jan 13, 2020 · 6 comments
Assignees

Comments

@for-coursera
Copy link

for-coursera commented Jan 13, 2020

When searching for processes in the search widget (called by either / or <C-f>), may be make this search case insensitive?

(Otherwise, everything seems to be working fine on macOS.)

@ClementTsang
Copy link
Owner

Hmmm, it should be case sensitive, it's just filtering using regex - I can't seem to reproduce this either (ie: typing 'discord' will not find the 'Discord' process for me on Linux). Could you send me an example/screenshot of the case where it's not properly filtering?

@for-coursera
Copy link
Author

for-coursera commented Jan 15, 2020

Hmmm, it should be case sensitive

It certainly is :)

And I'm asking you to consider making to INsensitive.

ie: typing 'discord' will not find the 'Discord' process

Exactly :). But don't you think that pressing Shift (and also not forgetting to do this) while searching for a process kinda slows down the whole workflow?

Anyway, thanks for your app ;)

@ClementTsang
Copy link
Owner

ClementTsang commented Jan 15, 2020

Oh, oops. I can't read. I blame my train breaking down for an hour.

Hmm... I get your point. I might consider adding a way to toggle between regex and just simple search. Would that work?

@for-coursera
Copy link
Author

I might consider adding a way to toggle between regex and just simple search

Sounds good but won't it be still an additional key press? May be a command line option instead?

@ClementTsang
Copy link
Owner

I'm thinking of adding some way of toggling but allowing a command line flag to allow you to choose a default search method upon first opening search. I'll take a look today and see how that might play out.

@ClementTsang ClementTsang self-assigned this Jan 16, 2020
@ClementTsang
Copy link
Owner

Along with having added the option a while ago, made case insensitive default with this commit: 616ba01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants