Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of the number of minimum replicas and extraManifests #103

Closed
wolviecb opened this issue Sep 25, 2023 · 1 comment · Fixed by #102
Closed

Allow setting of the number of minimum replicas and extraManifests #103

wolviecb opened this issue Sep 25, 2023 · 1 comment · Fixed by #102
Assignees
Labels
enhancement New feature or request

Comments

@wolviecb
Copy link
Contributor

Hi,

Thanks for the great work setting this repo! :)

I've noticed that when setting the ScaleJob you hard coded the minReplicaCount number to 0. While I understand the rationale of setting it to 0 I also wanted it to be possible to set it to an arbitrary value.

I've also wanted to be able to not pass secrets as plain text on the chart, it would be helpful to be able to create the secret apart from the main helm chart (e. g.: using sealed secrets and passing on the encrypted manifest)

I've created a PR that adds these features :)

@clemlesne clemlesne self-assigned this Nov 21, 2023
@clemlesne clemlesne linked a pull request Nov 21, 2023 that will close this issue
@clemlesne clemlesne added the enhancement New feature or request label Nov 21, 2023
@clemlesne
Copy link
Owner

Version 6.2.0 deployed, that's for you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants