Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Middleware file? #37

Closed
ciscoheat opened this issue Mar 18, 2015 · 4 comments
Closed

Deprecated Middleware file? #37

ciscoheat opened this issue Mar 18, 2015 · 4 comments

Comments

@ciscoheat
Copy link

The file https://github.com/clemos/haxe-js-kit/blob/dev/js/npm/connect/support/Middleware.hx won't compile as it is now (missing two imports), but it seems to be replaceable with https://github.com/clemos/haxe-js-kit/blob/dev/js/npm/express/Middleware.hx anyway. Remove it?

@clemos
Copy link
Owner

clemos commented Mar 19, 2015

Yeah I don't know what to do with Connect, now that Express is completely independant.
This file is part of the Connect extern I made for Express support.
I'm thinking about removing Connect entirely, now, in favor of Express, which I feel is better.
What do you think ?

@ciscoheat
Copy link
Author

I have the same feeling. If you think it's too much work to support both, remove Connect. It will hopefully lessen the confusion for newcomers as well.

@dionjwa
Copy link

dionjwa commented Jul 20, 2015

+1 It would be great to merge this into master since it currently doesn't compile. +1 for removing Connect.

@clemos
Copy link
Owner

clemos commented Oct 26, 2015

I think this is fixed, now (removed connect)

@clemos clemos closed this as completed Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants