Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup cannot not resolve './Crypto' from @clerk/clerk-sdk-node/esm/utils/index.js #356

Closed
1 of 11 tasks
ermartinez13 opened this issue Sep 2, 2022 · 4 comments
Closed
1 of 11 tasks

Comments

@ermartinez13
Copy link

Package + Version

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/clerk-expo
  • @clerk/backend-core
  • @clerk/clerk-sdk-node
  • @clerk/edge
  • other:

Version:

'@cleark/clerk-sdk-node': 4.1.3

Description

Rollup consistently returned the following message from a GitHub Actions job:

Error: Could not resolve './Crypto' from node_modules/@clerk/clerk-sdk-node/esm/utils/index.js

Due to the following import statement:

// node_modules/@clerk/clerk-sdk-node/esm/index.js
export * from './Crypto';

The file structure for the issue is as follows:

# within node_modules/@clerk:
clerk-sdk-node/
|-- esm/
|    |-- utils/
|         |-- crypto.js
|         |-- index.js

After some digging, I found this commit in a merged Rollup PR stating that imports are case sensitive.

Thus, it seems that because the import statement reads ./Crypto instead of ./crypto, the Rollup error is triggered.

I was able to work around this by using patch-package to fix the casing in the import statement.

To be honest, I'm not sure if this error is a non-issue from Clerk's side (perhaps there's a Rollup setting I overlooked) but hopefully this can help anyone else dealing with the same issue.

If this is a valid oversight from Clerk's side, let me know and I'll submit a PR request :)

@SokratisVidros
Copy link
Contributor

Hi @ermartinez13. Thanks for raising this. I am currently away from my laptop so can you please submit the PR? I can deploy a new version later today.

@SokratisVidros
Copy link
Contributor

This is now fixed in 4.1.4

@ermartinez13
Copy link
Author

This is now fixed in 4.1.4

Thanks!

P.S> I apologize for not submitting the PR, seems like I have my GH notifications off so I never saw the reply.

@SokratisVidros
Copy link
Contributor

No worries.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants