chore(*): Rename refs of MagicLink to EmailLink - deprecation warnings #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 2f66fe8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
js-643-rename-magiclink-js-docs
branch
2 times, most recently
from
a141709
to
335e105
Compare
dimkl
force-pushed
the
js-643-rename-magiclink-deprecated
branch
from
681e8a5
to
d1811bb
Compare
panteliselef
approved these changes
Oct 9, 2023
packages/shared/src/errors/Error.ts
Outdated
| @@ -178,6 +182,7 @@ export const MagicLinkErrorCode = { | |||
| Expired: 'expired', | |||
| Failed: 'failed', | |||
| }; | |||
| // TODO(@dimkl): Add deprecation warning for MagicLinkErrorCode | |||
There was a problem hiding this comment.
@dimkl will this be part of a followup PR ?
There was a problem hiding this comment.
i will update the current PR. I am trying to find if we could avoid adding a deprecation warning for this (eg it may not be exported or there is no real usage outside of our own SDKs)
There was a problem hiding this comment.
@panteliselef i've added a deprecation warning for MagicLinkErrorCode since it may be used by our customers
dimkl
force-pushed
the
js-643-rename-magiclink-deprecated
branch
from
d1811bb
to
479f50b
Compare
dimkl
force-pushed
the
js-643-rename-magiclink-deprecated
branch
from
479f50b
to
2f66fe8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warn about MagicLink deprecations:
MagicLinkErrorisMagicLinkErrorMagicLinkErrorCodehandleMagicLinkVerificationcreateMagicLinkFlowuseMagicLinkChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore