chore(clerk-sdk-node): Drop noisy deprecation of unstable_options in sdk-node #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 506337f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…sdk-node The `sdk-node` package is extending the backend `Clerk` with some extra methods. To do this, we expose a different `Clerk` from the `sdk-node` that returns the `clerkClient` instance of backend with some extra methods. To add those extra methods to the return value we currently destruct the `clerkClient` to a new object and add the extra methods. By destructing the `clerkClient`, all it's methods and properties are being accessed, causing the `__unstable_options` deprecation warning to trigger and show the warning every time in applications using the `sdk-node` package. To resolve this, we introduced an `ExtendedClerk` type as the return value of the sdk-node `Clerk` and changed the destructing to `Object.assign(clerkClient, ...extra...)`.
dimkl
force-pushed
the
fix-noisy-deprecations-sdk-node
branch
from
2d6badf
to
506337f
Compare
nikosdouvlis
approved these changes
Oct 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
sdk-nodepackage is extending the backendClerkwith some extra methods. To do this, we expose a differentClerkfrom thesdk-nodethat returns theclerkClientinstance of backend with some extra methods.To add those extra methods to the return value we currently destruct the
clerkClientto a new object and add the extra methods. By destructing theclerkClient, all it's methods and properties are being accessed, causing the__unstable_optionsdeprecation warning to trigger and show the warning every time in applications using thesdk-nodepackage.To resolve this, we introduced an
ExtendedClerktype as the return value of the sdk-nodeClerkand changed the destructing toObject.assign(clerkClient, ...extra...).Warning :
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore