Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing ?> in template/clerk/tracking.phtml #15

Closed
plasticid opened this issue Jan 4, 2016 · 5 comments
Closed

Trailing ?> in template/clerk/tracking.phtml #15

plasticid opened this issue Jan 4, 2016 · 5 comments

Comments

@plasticid
Copy link

Line 8 of app/design/frontend/base/default/template/clerk/tracking.phtml has an extra closing ?>
@brunsgaard
Copy link
Contributor

Thank you, I will look into it tomorrow ;)

@brunsgaard
Copy link
Contributor

https://github.com/clerkio/clerk-magento/blob/master/design/template/tracking.phtml#L7

line 7 is commented out, so the there is no extra ?>, you see?

@plasticid
Copy link
Author

The // doesn't comment out the ?> so there is a an extra ?> shown in the html.... /* */ would work though

@brunsgaard
Copy link
Contributor

Okay, I will never be good friends with PHP, I will fix it ;) Thanks again.

@brunsgaard
Copy link
Contributor

There you go, it will go into next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunsgaard @plasticid