New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_hub2_table(): Change class() to inherits() or is() #35

Closed

Tracked by

judith-bourque opened this issue Dec 5, 2022 · 1 comment

Closed

Tracked by

get_hub2_table(): Change class() to inherits() or is() #35

judith-bourque opened this issue Dec 5, 2022 · 1 comment

Labels

warning

Member

judith-bourque commented Dec 5, 2022 •

edited

Loading

When devtools::check() is run, the following note appears about clessnverse::get_hub2_table()

❯ checking R code for possible problems ... NOTE
  Found if() conditions comparing class() to string:
  File ‘clessnverse/R/dev_t.R’: if (!is.null(data_filter) && !class(data_filter) == "list" || length(data_filter) == 0) ...
  Use inherits() (or maybe is()) instead.

The line in question is 216 in clessnverse/R/dev_t.R

The text was updated successfully, but these errors were encountered:

judith-bourque added the warning label

judith-bourque changed the title ~~Change class() to inherits() or is()~~ get_hub2_table(): Change class() to inherits() or is()

judith-bourque mentioned this issue

Fix warnings and notes when running devtools::check() #65

Closed

7 tasks

Member Author

judith-bourque commented Jul 3, 2023

Closing as package no longer actively being developped as of #135.

judith-bourque closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment