Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is not compatible with Play Framework 2.3 #49

Closed
szymond opened this issue Jun 6, 2014 · 6 comments
Closed

Plugin is not compatible with Play Framework 2.3 #49

szymond opened this issue Jun 6, 2014 · 6 comments

Comments

@szymond
Copy link

szymond commented Jun 6, 2014

No description provided.

@hossein761
Copy link
Contributor

Hi, I am using it with Play 2.3 without any problems. What is the error you are getting?

@szymond
Copy link
Author

szymond commented Jun 8, 2014

I've been using version 0.8.2 of the plugin. As it turns out, while migrating to play 2.3, I've also upgraded scala version to 2.11 and it seems it caused some compile-time conflicts. When I've downgraded my play application back to 2.10, compile time errors disappeared. Still, I believe making the plugin work with scala 2.11 would be nice.

@szymond szymond closed this as completed Jun 8, 2014
@Enalmada
Copy link

Enalmada commented Jun 8, 2014

+1. Having a build against play 2.3 and scala 2.11.1 would be very convenient.

@mguillermin
Copy link
Contributor

You're right. Building against scala 2.10 & 2.11 can probably be achieved using the crossPaths setting in the build definition. I just have to check that this do not affect the publishing on the Sonatype OSS repository.

Regarding the build against different versions of Play, I don't know what strategy to adopt. How should we name versions consistently in this case ? I'm open to any suggestions.

@ojacquemart
Copy link

Temporary, it's working by excluding the 2.10 dependencies:

libraryDependencies ++= Seq(
  ("com.clever-age" % "play2-elasticsearch" % "1.1.0")
    .exclude("com.typesafe.play", "play-functional_2.10")
    .exclude("com.typesafe.akka", "akka-actor_2.10")
    .exclude("com.typesafe.play", "play-json_2.10")
    .exclude("com.typesafe.play", "play_2.10")
    .exclude("com.typesafe.play", "play-iteratees_2.10")
    .exclude("com.typesafe.akka", "akka-slf4j_2.10")
    .exclude("org.scala-stm", "scala-stm_2.10")
    .exclude("com.typesafe.play", "play-datacommons_2.10")
)

@fastf0rward
Copy link

+1

Using @ojacquemart 's workaround I still got 1 conflicting dependency (running Play 2.3.5). After adding the line below to the excludes, all's fine now:

.exclude("com.typesafe.play", "play-java_2.10")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants