Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Callback #15

Closed
toinevk opened this issue Jul 10, 2017 · 2 comments
Closed

OAuth Callback #15

toinevk opened this issue Jul 10, 2017 · 2 comments
Labels

Comments

@toinevk
Copy link
Contributor

toinevk commented Jul 10, 2017

I noted that currently for OAuth the callback function (in OAuthLoginButton) only sends a message during failure and does nothing during success (e.g. push to /documents). Is that intentional or am I missing something obvious? I would've thought it would be desirable to have the OAuth logins/signup consistently show a message / push to /documents as well.

Thanks, I appreciate the insight.

@cleverbeagle
Copy link
Owner

@toinevk to make sure I understand, when you login via OAuth, are you not being redirected to /documents? This is the intended behavior, however, in the case of Pup the redirect for OAuth's isn't handled in the button callback but in the /imports/ui/components/Public/Public.js component (it redirects away from public pages to /documents if it sees a logged-in user).

@toinevk
Copy link
Contributor Author

toinevk commented Jul 11, 2017

I've tried reproducing with a fresh copy of pup but haven't been able to. Must have made a change that was interfering with the public component somehow. Thanks :)! The boilerplate is great by the way.

@toinevk toinevk closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants