Add integration and validation tools: TravisCI + CodeClimate & Some refactor fixes #15
Conversation
- Strict comparison - Yoda notation - Spacing/indention
JoryHogeveen
changed the title
|
Wow, this is great. I haven't had any time to put into this plugin. I don't have any thoughts on unit tests for it, other than I like the idea. I will check this over in the next few days, hopefully. |
|
Hi Cindy, no problem about the ideas, I have some allthough it does need some refactoring. |
|
Hi Cindy, did you manage to check the PR? Let me know! |
|
I have just been swamped with client work and family life the past two months so I've had no time to look at it. I've added you to this repo and to the wp.org repository as a contributor (I think that should give you SVN access). I hate seeing this plugin too stagnant seeing as there's now over 100,000 users. I'll merge this PR and set up those two accounts and enable them on the repo. Go ahead and push any updates to the wp.org repo if you can access it, if they're all working. Many thanks for your contributions to this plugin. |
|
Hi Cindy, No problem at all, and thanks for adding me! And I will definitely add any enhancements when I have the time. #16 is one I'd like to pick up a.s.a.p. Thanks! |
|
They should be enabled now.
…On Mon, Jun 19, 2017 at 2:44 PM, Jory Hogeveen ***@***.***> wrote:
Hi Cindy,
No problem at all, and thanks for adding me!
Let me know when Travis and CodeClimate are enabled so I can take a look.
And I will definitely add any enhancements when I have the time. #16
<#16> is one I'd
like to pick up a.s.a.p.
I didn't get any notice from the WP repo yet but maybe that could take
some time.
Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA90RFsn7e3sD_JB0hsCYrnIFykz0Guyks5sFsGggaJpZM4NMUhw>
.
--
*Cindy Kendrick*
*Co-Founder, CodeBrain Media LLC*
<http://goog_856386009>
http://codebrainmedia.com
cindy@codebrainmedia.com
<cindy@codebrainmedia.com>
|
|
Yep it works, TravisCI tests now running and passing. I will push codeclimate fixes to this branch and make a new PR when ready. |
Me again!
I noticed this plugin isn't using any CI tools yet so could be a good way to check everything with different versions etc. before deploying on the WP repository.
This PR will add all the required files to integrate with TravisCI and CodeClimate (both free tools for open source projects). You just need to create an acount on both with your GitHub login and enable it for this repository once the PR is merged.
I've also put some minor fixes in there (see "Other changes"). Left all logic as it is (mostly added some changes like strict comparison and yoda notation).
Checks done with TravisCI:
Allowed failures:
Checks done with CodeClimate
I haven't customized this yet.
PHP Mess Detector
PHP Code Sniffer
https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards
Other changes:
TODO: