Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Linux OSes not built with glibc #36

Closed
cleydyr opened this issue Feb 16, 2024 · 3 comments
Closed

Support Linux OSes not built with glibc #36

cleydyr opened this issue Feb 16, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@cleydyr
Copy link
Owner

cleydyr commented Feb 16, 2024

Dart Sass has released Sass packages compatible with Linux OSes not built with glibc (Alpine, for example.) Since version 1.69.6. See sass/dart-sass#2148 and sass/dart-sass#1924.

This issue tracks adding an optional plugin flag to download the musl Sass release for Linux instead of the glibc (i.e., the regular) one.

@cleydyr cleydyr added the enhancement New feature or request label Feb 16, 2024
@cleydyr
Copy link
Owner Author

cleydyr commented Feb 16, 2024

Depends on sass/dart-sass#2174 for testing.

@cleydyr
Copy link
Owner Author

cleydyr commented Feb 16, 2024

I think adding a new (pseudo) OSlinux-musl is better to avoid the risk of users mistakenly setting a flag for operating systems other than Linux. That also dispenses with cascading internal changes (a new parameter and a new constructor and field for DartSassReleaseParameter) to support the flag.

@cleydyr
Copy link
Owner Author

cleydyr commented Feb 24, 2024

Included in v1.3.0. Closing this issue.

@cleydyr cleydyr closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant