Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cli-tabe3 for shyim/ssh-host-manager #51

Closed
schalkneethling opened this issue Oct 4, 2018 · 4 comments
Closed

Update to cli-tabe3 for shyim/ssh-host-manager #51

schalkneethling opened this issue Oct 4, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@schalkneethling
Copy link
Contributor

schalkneethling commented Oct 4, 2018

Steps to complete

  • Go to and fork the following repository: https://github.com/shyim/ssh-host-manager
  • Once forked, open the project in your editor of choice, and search the project for the string cli-table2
  • Change all of these references to cli-table3, particularly ensuring that the dependency in `package.json is updated to read:
"cli-table3": "^0.5.0",
  • Open a pull request to the original repository
  • Add a comment here linking to your PR

You can use the following copy as the title and description of your pull request:

Title

Updates dependency cli-table2 to cli-table3

Description

This PR updates the cli-table2 dependency to cli-table3, which fixes one of the npm audit warnings :)

cli-table2 (like cli-table itself) is no longer maintained. In jamestalmage/cli-table2#43 a couple of people have offered to take over maintenance but the current maintainer did not respond so as a result the project was forked to cli-table/cli-table3.

@TremaineNeethling
Copy link

shyim/ssh-host-manager#1

@macieklad
Copy link
Contributor

macieklad commented Oct 4, 2018

Hello, I was working in the pararell on this issue, and while I was refactoring the typescript code, I found and error #54 , can you take a look ?

@TremaineNeethling
Copy link

My pull request has been merged.

@schalkneethling
Copy link
Contributor Author

Thanks @TremaineNeethling 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants