Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign gh.exe binaries in addition to signing the MSI installer #2111

Closed
mislav opened this issue Oct 6, 2020 · 1 comment · Fixed by #2160
Closed

Sign gh.exe binaries in addition to signing the MSI installer #2111

mislav opened this issue Oct 6, 2020 · 1 comment · Fixed by #2160
Labels
enhancement a request to improve CLI help wanted Contributions welcome packaging windows

Comments

@mislav
Copy link
Contributor

mislav commented Oct 6, 2020

This would help identify Windows binaries that were officially packaged by us vs. ones that might have been modified/corrupted. Right now, we only do signing with the MSI installer.

Ref. #2064
Followup to #148

@mbpreble
Copy link

Hoping to have a draft PR up for this within a few days. I think there's a path to signing the Windows binaries in a post-build hook. Mono's signcode util is available in ubuntu (need 20.04 or a manual update of Mono for the ability to sign with sha256).

@samcoe samcoe added the enhancement a request to improve CLI label Oct 12, 2020
@vilmibm vilmibm added the help wanted Contributions welcome label Oct 22, 2020
@vilmibm vilmibm mentioned this issue Apr 27, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a request to improve CLI help wanted Contributions welcome packaging windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@mislav @vilmibm @mbpreble @samcoe and others