Ask before merging if CI failed or is pending

[camelid]

Describe the feature or problem you’d like to solve

In the GitHub.com UI, the 'Merge pull request' button is not filled in if CI failed or is still pending. However, the GitHub CLI does not notify you if the checks failed or if they are still pending when you run gh pr merge. It would be helpful to ask 'Are you sure?' if CI failed or is pending so that one does not need to remember to run gh pr checks before merging.

Proposed solution

Add an 'Are you sure?' prompt at the beginning of the gh pr merge workflow if CI failed or is pending. I'm thinking something like:

$ gh pr merge
? Some checks failed. Are you sure you want to merge? (y/N)
? What merge method would you like to use?  [Use arrows to move, type to filter]
...

and this if checks are pending:

$ gh pr merge
? Some checks are still pending. Are you sure you want to merge? (y/N)
? What merge method would you like to use?  [Use arrows to move, type to filter]
...

[mislav]

This is a great idea. Makes sense to ship in tandem with #1198 👍

@ampinsk What do you think?

[ampinsk]

I love this idea! The proposed prompt makes sense to me 👍

[darcyclarke]

Hey @camelid, it seems like we already support this behavior/throwing if you add required CI status' to your branch protection rules/repo settings.

[camelid]

Ah, I didn't know that. It might still be useful to have a warning even if the user doesn't have enforced branch protection though. The web UI has a visual clue of whether checks have passed based on the color of the merge button, whereas AFAIK there's nothing like that in the CLI.