Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git editor aliases are not executed #6011

Closed
cravend opened this issue Jul 28, 2022 · 2 comments
Closed

Git editor aliases are not executed #6011

cravend opened this issue Jul 28, 2022 · 2 comments
Labels
bug Something isn't working needs-triage needs to be reviewed

Comments

@cravend
Copy link

cravend commented Jul 28, 2022

Describe the bug

A while ago, I aliased vim to nvim as part of my transition into neovim. However, I forgot to update my core.editor git config. Git itself appropriately handles the alias, but when the editor is opened via gh, normal vim opens (without my vim config).

Steps to reproduce the behavior

  1. Alias what core.editor is set to to be something else
  2. Trigger an editor opening via gh
  3. See that the editor opened is incorrect

Expected vs actual behavior

It opens the correct editor — in my case, neovim. (p.s: I know the solution to my problem is to just edit my .gitconfig, but I wanted to report it nonetheless. This feels like it's tied to #925, but I'm not sure).

Logs

A screenshot of a terminal editor (neovim) opened by Git. A screenshot of a terminal editor (vim) opened by GitHub CLI.
@cravend cravend added the bug Something isn't working label Jul 28, 2022
@cliAutomation cliAutomation added the needs-triage needs to be reviewed label Jul 28, 2022
@yungfletchr361

This comment was marked as spam.

@samcoe
Copy link
Contributor

samcoe commented Aug 2, 2022

@cravend Thanks for opening the issue. This is indeed the same issue as #925. Going to close this as a duplicate, please watch #925 for any further development on the issue.

@samcoe samcoe closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage needs to be reviewed
Projects
None yet
Development

No branches or pull requests

4 participants