Disable gh update checker in our precompiled binaries #6977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because most people install gh through a package manager, and people usually prefer for their package manager to check for updates instead of the gh process doing it at runtime.
samcoe
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because most people install gh through a package manager, and people usually prefer for their package manager to check for updates instead of the gh process doing that at runtime.
After this, the only people still receiving update notifications would be Homebrew users, since the homebrew-core formula sets
main.updaterEnabledexplicitly.Note that this also disables automatic update checking for Windows users who have installed the MSI. After this, MSI users will not learn about gh having new versions unless they perform the check themselves.
Fixes #6966, ref. #6867