Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle C1 control sequences #7079

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Properly handle C1 control sequences #7079

merged 3 commits into from
Mar 7, 2023

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Mar 2, 2023 •
edited

@samcoe samcoe self-assigned this Mar 2, 2023
@samcoe samcoe marked this pull request as ready for review March 2, 2023 23:16
@samcoe samcoe requested a review from a team as a code owner March 2, 2023 23:16
@samcoe samcoe requested review from vilmibm and removed request for a team March 2, 2023 23:16
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Mar 2, 2023
vilmibm
vilmibm approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you~

do you think there is value in splitting this out into a Go package? I kind of want it for a side project 😅

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Mar 3, 2023
@samcoe
Copy link
Contributor Author

samcoe commented Mar 5, 2023

@vilmibm Potentially. It is specific to how GitHub does encoding of these values though. We might be doing it a standardized way, haven't heard from the platform team about that yet. Perhaps it belongs in go-gh.

@samcoe samcoe merged commit 44b0218 into trunk Mar 7, 2023
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Mar 7, 2023
@samcoe samcoe deleted the ascii-2 branch March 7, 2023 01:44
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees

@samcoe samcoe

Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samcoe @vilmibm