Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinforce not opening PRs without approval on an issue #7974

Merged
merged 1 commit into from Sep 12, 2023

Conversation

williammartin
Copy link
Member

Description

To be honest, the first time I read the CONTRIBUTING guide I jumped to the bullet points and didn't really give a lot of weight to the sentence:

We accept pull requests for bug fixes and features where we've discussed the approach in an issue and given the go-ahead for a community member to work on it.

This just adds to the please avoid section to reinforce this idea.

@williammartin williammartin requested a review from a team as a code owner September 11, 2023 13:19
@williammartin williammartin requested review from andyfeller and removed request for a team September 11, 2023 13:19
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Sep 11, 2023
Copy link
Contributor

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@williammartin williammartin merged commit 4cd0b73 into trunk Sep 12, 2023
7 checks passed
@williammartin williammartin deleted the williammartin-patch-1 branch September 12, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Needs review 🤔
Development

Successfully merging this pull request may close these issues.

None yet

2 participants