gh cs ssh --config
does not add quotes to the CLI path on Windows
#8907
Labels
gh cs ssh --config
does not add quotes to the CLI path on Windows
#8907
Describe the bug
When running
gh cs ssh --config
, the configuration will contain a proxy command, which uses the GitHub CLI. On Windows, the path to the CLI binary used in that command is not quoted even when it contains whitespaces, causing problems with applications that attempt to use it to connect via ssh.Manually editing the generated configuration to add the missing quotes allows normal use of the proxy command.
Version 2.46.0 (2024-03-20)
Steps to reproduce the behavior
gh cs ssh --config
.ProxyCommand
section of the output:ProxyCommand C:\Program Files\GitHub CLI\gh.exe cs ssh ...
.C:\Program Files\GitHub CLI\gh.exe
, which should be quoted as it contains whitespaces.Expected vs actual behavior
The CLI should output a quoted path to the binary when required:
ProxyCommand "C:\Program Files\GitHub CLI\gh.exe" cs ssh ...
ProxyCommand C:\Program Files\GitHub CLI\gh.exe cs ssh ...
The text was updated successfully, but these errors were encountered: