New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MLP intermediate dimension not used #7

Closed

weimingzha0 opened this issue Oct 5, 2023 · 0 comments

Labels

bug

Contributor

weimingzha0 commented Oct 5, 2023

model_config.ffn_embed_dim is not used. Instead it used 4x hidden_dim

weimingzha0 added the bug label

weimingzha0 mentioned this issue

Fix weight computation for MLP #8

Merged

cli99 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment