Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No test files in sdist tarball #39

Closed
dvzrv opened this issue Jan 20, 2022 · 4 comments · Fixed by #44
Closed

No test files in sdist tarball #39

dvzrv opened this issue Jan 20, 2022 · 4 comments · Fixed by #44
Labels

Comments

@dvzrv
Copy link

dvzrv commented Jan 20, 2022

Hi! I'm packaging this for Arch Linux. We usually rely on sdist tarballs on pypi.org and run the tests of each project (if possible) that we package.

Unfortunately the tests are missing from the sdist tarball and I have to revert to using the auto-generated tarball on github (which is also possible for me to use). However, would it be possible for you to add the tests also to the sdist tarball? Thanks! :)

@espdev
Copy link
Member

espdev commented Jan 21, 2022

Hi @dvzrv,

There is no difficulty in adding tests directory to sdist. I can just update MANIFEST.in file and make a new release. However, pytest package is required to run tests. install target does not install dependencies for testing. Currently, we have extra dependencies (extras_require) tests to install pytest and other packages for testing.

@espdev
Copy link
Member

espdev commented Jul 16, 2022

For now, I'm closing the issue. Please let me know if this is still important to someone.

@espdev espdev closed this as completed Jul 16, 2022
@espdev espdev added the testing label Jul 16, 2022
@dvzrv
Copy link
Author

dvzrv commented Oct 12, 2022

Please let me know if this is still important to someone.

Yes, this is important to me. Otherwise I would not have opened the issue :)

It is completely fine, that the install target does not install pytest. If a downstream wants to run the test, they will install the required dependencies. However, without the test files this is not possible at all.

@espdev
Copy link
Member

espdev commented Oct 12, 2022

tests directory was added in 0.5.5 release
https://pypi.org/project/click-option-group/0.5.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants