Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py needs README.md, but it is not in the tar.gz package #12

Closed
andy-maier opened this issue Dec 8, 2016 · 1 comment
Closed

Comments

@andy-maier
Copy link

The setup.py file depends on the presence of README.md, but that file is not included in the .tar.gz version of the package.

With v0.1.4, this problem now comes up because the tar.gz version is the only one available on PyPI, so pip picks it.

With v0.1.3, this problem existed as well, but did not come up when installing via pip install click-spinner, because a .whl version existed in addition on PyPI, and pip apparently prefers the .whl version over the .tar.gz version. I don't fully understand why this does not surface in the .whl version, but I suspect that pip does not execute the setup.py when installing a .whl archive.

@andy-maier
Copy link
Author

PR #13 adds the README.md file to the .tar.gz source distribution archive.

In addition, it would probably be good to also upload a .whl to PyPI, and to automate the build&upload process with a makefile or the like...

@yoavram yoavram closed this as completed in fccafa3 Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant