Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar image small and fuzzy #47

Open
NickToye opened this issue Apr 15, 2015 · 4 comments · May be fixed by #51
Open

Avatar image small and fuzzy #47

NickToye opened this issue Apr 15, 2015 · 4 comments · May be fixed by #51

Comments

@NickToye
Copy link

The image of the avatar is coming through at 48x48 and seems very fuzzy. Apologies if this is a known issue or something that is out of your control.

@bryanburgers
Copy link
Contributor

Hmm. Good call.

It looks like the Twitter API returns 48×48 pixel profile images (source). But it's possible to mangle the URL and get larger profile images (source).

This issue would be a good opportunity for somebody to contribute to the project with a pull request.

@NickToye
Copy link
Author

I'd love to be able to contribute, but I'm just not a php developer. I can look at things, and try and make sense of it, but its way out of my comfort zone. Maybe I'll take a look at the code and if I can identify what needs to change I'll contribute with a pull request. Might be a good opportunity to develop some experience in this area.

@bryanburgers
Copy link
Contributor

If you want to try to tackle this, you'll probably be looking at this code where that information is set, and you'll want to do some string manipulation to get the new URL. You'll probably end up with something like:

$largeUrl = // some string manipulation using $val['user']['profile_image_url_https']
$variables[$userprefix . 'image:large'] = $largeUrl;

Give it a shot. Get as far as you can and open a pull request. From there, we can see if you need further input to get to the end, or if one of the maintainers can just roll with it and finish it up. But I think you can do it.

@NickToye
Copy link
Author

Ok, that's where I've got lost right off the bat. String manipulation is one of those phrases that make me reach for another shot of bourbon. :)

tobystokes added a commit to tobystokes/EE_Twitter that referenced this issue Feb 25, 2016
@tobystokes tobystokes linked a pull request Feb 25, 2016 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants