Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any interest in updating this project? #6

Closed
scohen opened this issue Mar 27, 2019 · 3 comments
Closed

Any interest in updating this project? #6

scohen opened this issue Mar 27, 2019 · 3 comments

Comments

@scohen
Copy link
Contributor

scohen commented Mar 27, 2019

Hi,
I have a fork of Clickhousex where I updated this project to use the latest Ecto / DBConnection. I also fixed some bugs and added more thorough type handling. I also added a lot of tests.

Additionally, I have a branch that uses different output formats from Clickhouse that should make for more efficient queries.

Would you be interested in a PR?

@scohen scohen changed the title Interest in updating this project Any interest in updating this project? Mar 28, 2019
@santaux
Copy link
Contributor

santaux commented Apr 4, 2019

Hi @scohen,
Yeah, sure, we are interested in any updates you can make :)

@scohen
Copy link
Contributor Author

scohen commented Apr 4, 2019

Alright. I also made this pr that switches the response format to binary and handles all of the types that clickhouse supports. It also allows for setting the request and response types via codecs. I noticed there was a bit of conversion from the clickhouse JSON format into the list of tuples format that ecto wants, and clickhouse supports the JSONCompact format, which is a direct mapping to what ecto requires, so that should be more efficient (though, my testing didn't indicate a bottleneck in decoding queries).

If you're interested, I'll push that here as well.

@scohen
Copy link
Contributor Author

scohen commented Jun 6, 2019

Welp, this is done now. Thanks!

@scohen scohen closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants