New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error for postgresql CREATE TABLE #99

Closed

japinli opened this issue Apr 12, 2023 · 1 comment · Fixed by #100

japinli commented Apr 12, 2023

Hi, When I use ClickHouse run benchmark for PostgreSQL, I found there is a syntax error in create.sql. Here we should remove the last comma.

diff --git a/postgresql/create.sql b/postgresql/create.sql
index 10185d5..41c961c 100644
--- a/postgresql/create.sql
+++ b/postgresql/create.sql
@@ -104,5 +104,5 @@ CREATE TABLE hits
     HasGCLID SMALLINT NOT NULL,
     RefererHash BIGINT NOT NULL,
     URLHash BIGINT NOT NULL,
-    CLID INTEGER NOT NULL,
+    CLID INTEGER NOT NULL
 );

Member

alexey-milovidov commented Apr 22, 2023

@japinli, please send a pull request.

nickitat linked a pull request

that will close this issue

Fix typo in postgresql/create.sql #100

Merged

nickitat closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment