Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netconf Confirmed Commit Capability #255

Closed
olofhagsand opened this issue Aug 5, 2021 · 1 comment
Closed

Netconf Confirmed Commit Capability #255

olofhagsand opened this issue Aug 5, 2021 · 1 comment

Comments

@olofhagsand
Copy link
Member

Implement Netconf Confirmed Commit Capability according to RFC 6241

The current code only has a placeholder for the cancel-commit operation in backend_client.c, nothing else is implemented, except for the generic mechanism given by ietf-netconf@2011-06-01.yang

Some comments/hints:

  • A timeout can be set using clixon_event_reg_timeout().
  • If persistence is used, it is not enough to save the previous config state in server memory. One way to achieve consistency is to save restoration state using a temporary datastore. The datastore API in clixon_datastore.h works on any db and could be used for this purpose. Eg xmldb_copy("running", "persistent-db")
  • Reverting state on timeout/cancel could be made by copying back from persistent-db to candidate and then issuing a commit.
@olofhagsand
Copy link
Member Author

FIxed privileges drop and check running lock completes all unknown issues.
Thanks @pheller for the major part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant