Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove DataArchive properties that rely on manager calls #72

Closed
delgadom opened this issue Jan 2, 2017 · 1 comment
Closed

remove DataArchive properties that rely on manager calls #72

delgadom opened this issue Jan 2, 2017 · 1 comment
Assignees
@jgerardsimcock
Labels
enhancement test-breaker
Milestone
MVP

Comments

@delgadom
Copy link
Member

delgadom commented Jan 2, 2017

The fact that these are properties is potentially confusing and could lead to unintended calls to the manager.

Propose changing the following properties into functions:

  • latest_version --> get_latest_version
  • versions --> get_versions
  • latest_hash --> get_latest_hash
  • history --> get_history
  • metadata --> get_metadata

These changes would break tests and docs/examples which explicitly rely on these properties.
@delgadom delgadom added this to the MVP milestone Jan 2, 2017
@jgerardsimcock jgerardsimcock self-assigned this Jan 4, 2017
@jgerardsimcock jgerardsimcock mentioned this issue Jan 4, 2017
Merged
@jgerardsimcock
Copy link
Contributor

merged in #74

@delgadom delgadom mentioned this issue Jan 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgerardsimcock jgerardsimcock

Labels
enhancement test-breaker
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@delgadom @jgerardsimcock