Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User PATCH does not work correctly after refreshing access token #156

Closed
CrownKira opened this issue Oct 29, 2022 · 3 comments · Fixed by #154
Closed

User PATCH does not work correctly after refreshing access token #156

CrownKira opened this issue Oct 29, 2022 · 3 comments · Fixed by #154
Assignees
Labels
bug.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u
Milestone

Comments

@CrownKira
Copy link
Contributor

CrownKira commented Oct 29, 2022

Describe the bug
A clear and concise description of what the bug is.

Reproduce:

  • Set access token expiry to 5s
  • Go to user profile page
  • Edit something
  • Hit submit
  • Observe that the returned response does not update the user even though it says 200 OK

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@CrownKira CrownKira added the bug.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u label Oct 29, 2022
@CrownKira CrownKira added this to the Week 5-6 milestone Oct 29, 2022
@chownces
Copy link
Collaborator

Investigated this. Most likely due to the way the FE is replaying the request during the refresh token flow. The backend is receiving an empty body in the replayed request.

@CrownKira CrownKira mentioned this issue Oct 29, 2022
1 task
@therizhao
Copy link
Contributor

This one closed?

@chownces
Copy link
Collaborator

chownces commented Nov 1, 2022

Yup can close. Due to the content type header not being set correctly in the replay. So backend didnt recognise the body as json.

@chownces chownces closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants