Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix telegram username form #80

Merged
merged 8 commits into from Oct 14, 2022
Merged

Fix telegram username form #80

merged 8 commits into from Oct 14, 2022

Conversation

therizhao
Copy link
Contributor

@therizhao therizhao commented Oct 14, 2022 •
edited

Describe your changes

Issue ticket number and link

#60

Screenshots (if appropriate):

image

image

Checklist before requesting a review

  • I have performed a self-review of my code

@therizhao therizhao added the bug.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u label Oct 14, 2022
@netlify
Copy link

netlify bot commented Oct 14, 2022 •
edited

✅ Deploy Preview for transcendent-genie-268c15 ready!

Name Link
🔨 Latest commit 65cecd8
🔍 Latest deploy log https://app.netlify.com/sites/transcendent-genie-268c15/deploys/6349313ac202780008091744
😎 Deploy Preview https://deploy-preview-80--transcendent-genie-268c15.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 14, 2022 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 65cecd8
Status:⚡️  Build in progress...

View logs

Artemis-Hunt
Artemis-Hunt reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@Artemis-Hunt Artemis-Hunt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Besides the typo below)

Artemis-Hunt
Artemis-Hunt reviewed Oct 14, 2022
View reviewed changes
frontend/src/sections/auth/login/LoginForm.tsx Outdated

// ----------------------------------------------------------------------

export default function LoginForm() {
useEffect(() => {
document.querySelector('ifrmae');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo iframe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

chownces
chownces requested changes Oct 14, 2022
View reviewed changes
frontend/src/sections/auth/login/LoginForm.tsx Outdated
Comment on lines 14 to 16
useEffect(() => {
document.querySelector('ifrmae');
}, []);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@therizhao
Copy link
Contributor Author

Removed unnecssary useffect

@chownces chownces merged commit 96dbb82 into main Oct 14, 2022
@chownces chownces deleted the fix/telegram-username branch October 17, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artemis-Hunt Artemis-Hunt Artemis-Hunt left review comments

@chownces chownces chownces approved these changes

@CrownKira CrownKira Awaiting requested review from CrownKira

@kwokieee kwokieee Awaiting requested review from kwokieee

Assignees
No one assigned
Labels
bug.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u type.Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@therizhao @chownces @Artemis-Hunt