-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update spectral arrays that have been modified #56
Comments
Yes, makes sense. of course, if you modify any wind field both vorticity and divergence must be updated. Since this part of the code is not expected to be called frequently in practice, I did not bother to optimise it. |
I'd expect it to be pretty frequent that someone might update humidity and temperature, for example, just at the surface in a surface flux scheme. |
sure, but that will have to be tested to see if it actually works. Every spectral dycore based GCM that I have seen uses a finite difference version of implicit components like surface schemes. |
Ah, yeah you're right, surface schemes should be Prognostic and passed into the dycore. |
fixed by #68 |
In GFS, currently if any arrays have been modified then all spectral arrays will be re-generated. However, we only need to re-generate those spectral arrays whose physical counterpart has been modified.
The text was updated successfully, but these errors were encountered: