New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUES: JavaScript best practices #6

Closed

clintonjosephs opened this issue Jan 17, 2022 · 1 comment

Owner

clintonjosephs commented Jan 17, 2022

Below are some issues I noticed with my code based on JavaScript based practices

It would be nice to refactor loop in UpdateToDoItemIndex to use ForEach loop instead of the good old for loop
Consider pushing all variable declarations within markListForChanges AND swapItems to the beginning of its block
Based on JavaScript best practices, it would be nice to initialize this variable

Owner Author

clintonjosephs commented Jan 18, 2022

Fixed

clintonjosephs closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment