Add DEBUG=1 flag #2156
Merged
Add DEBUG=1 flag #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjethani
commented
Aug 12, 2021
| @@ -75,4 +75,11 @@ module.exports = class TSUrlFilter { | |||
| const result = this.engine.matchRequest(request); | |||
| return result.getBasicResult(); | |||
| } | |||
|
|
|||
| matchDebug({ url, frameUrl, type }) { | |||
There was a problem hiding this comment.
The idea is that matchDebug() returns something more useful than just a boolean value. In both the cases here (adblockplus and tsurlfilter) it returns the filter text.
mjethani
commented
Aug 12, 2021
| const match = engine.match({ type: WEBREQUEST_OPTIONS[cpt], frameUrl, url }); | ||
|
|
||
| let matchDebug = null; | ||
| if (engine.matchDebug) { |
There was a problem hiding this comment.
If the engine does not implement matchDebug() the default value is null. In the end every engine should implement something useful.
mjethani
commented
Aug 12, 2021
| output.push({ index, url, frameUrl, cpt, match, matchDebug }); | ||
| } | ||
|
|
||
| fs.writeFileSync(`./${ENGINE}.debug.json`, JSON.stringify(output, null, 2)); |
There was a problem hiding this comment.
Output is pretty so it can be used with tools like diff.
|
I also have a In the end it should be possible to do this: |
remusao
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
DEBUG=1flag.The above should generate a file called
adblockplus.debug.jsonin the current directory.