Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Adblock Plus whitelisting logic #2172

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Add Adblock Plus whitelisting logic #2172

merged 1 commit into from
Aug 13, 2021

Conversation

mjethani
Copy link
Contributor

@mjethani mjethani commented Aug 13, 2021 •
edited
Loading

Based on the discussion here: #2170

This patch adds whitelisting logic for Adblock Plus.

With this patch we get the same results as tsurlfilter.

make adblockplus DEBUG=1
make tsurlfilter DEBUG=1 COMPARE=adblockplus.debug.json

tsurlfilter.diff.json contains no entries.

@ameshkov @remusao

@mjethani mjethani marked this pull request as ready for review August 13, 2021 13:57
@mjethani mjethani requested a review from remusao as a code owner August 13, 2021 13:57
@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 13, 2021
@remusao remusao merged commit 1bb6076 into ghostery:master Aug 13, 2021
@mjethani mjethani deleted the abp-whitelisting branch August 13, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjethani @remusao