Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider supporting globbing in regexps #73

Closed
remusao opened this issue Dec 11, 2018 · 1 comment
Closed

Consider supporting globbing in regexps #73

remusao opened this issue Dec 11, 2018 · 1 comment

Comments

@remusao
Copy link
Collaborator

remusao commented Dec 11, 2018

I still don't think we should support full regexps in filter syntax, although having a more limited for like globbing could allow some more efficient filters in some cases.

||foo.bar/{scripts,ads,tracking}$xhr

This would allow to encode several possibilities in a single filter, with a clear syntax.
@remusao remusao mentioned this issue Jan 8, 2019
Merged
@remusao
Copy link
Collaborator Author

remusao commented Jun 25, 2019

We now have full RegExp support so closing this as won't fix

@remusao remusao closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remusao