Remove tldts dependency and allow to plug any implementation instead #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remusao
force-pushed
the
remove-tldts-dependency
branch
from
eabc2df
to
86a7eeb
Compare
zhonghao-cliqz
approved these changes
Jan 8, 2019
* Adblocker does not include tldts by default anymore * API now expect either already constructed Request as argument of both hostname and domain when needed (e.g.: getCosmeticsFilters) * A makeRequest helper is provided to construct Request objects * [BREAKING] engine.match expects a `Request` as argument * [BREAKING] engine.matchAll expects a `Request` as argument * [BREAKING] engine.getCSPDirectives expects a `Request` as argument * [BREAKING] engine.getCosmeticsFilter expects a new `domain` argument * [BREAKING] `Request`'s constructor does not apply default value anymore and expects all arguments to be provided and initialized. You can now use `makeRequest` to reproduce the previous behavior of `new Request`.
remusao
force-pushed
the
remove-tldts-dependency
branch
from
86a7eeb
to
2a09d4a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hostname and domain when needed (e.g.: getCosmeticsFilters)
Requestas argumentRequestas argumentRequestas argumentdomainargumentRequest's constructor does not apply default value anymore and expects all arguments to be provided and initialized. You can now usemakeRequestto reproduce the previous behavior ofnew Request.This will allow two things:
@zhonghao-cliqz @chrmod