Fix maximum number of selectors in stylesheet limitation on Chrome #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remusao
force-pushed
the
fix-maximum-selectors-chrome
branch
from
fb8e6e4
to
788a732
Compare
zhonghao-cliqz
approved these changes
Jan 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to Zhonghao for first noticing this bug. Chrome currently will never allow more than 8192 selectors in CSS rules because of some implementation limitation (use of 13 bits in
RuleData). See here for more details: https://crbug.com/804179We now split selectors into multiple blocks to make sure we do not run into this issue.