-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hybi-10 Standard #31
Comments
I'm probably not going to get to this until 0.2.0 is released, but patches are always welcome. |
Actually, the fix was pretty simple, so I added it in. The 'new' branch should support the latest version of Chrome. |
Wow! Nice to hear :) Sadly, it looks like the change in the handshake wasn't the only one. Chrome is able to connect without problems, sent messages doesn't get through. Similar, messages to Chrome doesn't come through.
I suspect the framing of packets changed as well. |
Ha, I suppose I should have tested more than the handshake. I'm using the built-in websocket support in Netty, but from what I recall I think it should be dead simple to reproduce the protocol I was familiar with. If the new one is similarly straightforward, I can definitely do that too. Since I've already come this far, I'd like to get this working in the current release. I'll keep you posted. |
Done! There are a few places I need to clean up, but you should be able to send text messages back and forth in Chrome. Let me know if this isn't working for you. |
Whoops, forgot to close this. |
Chrome implements in the hybi-10 standard since 14.0.835 (Dev-Channel). Because of changes in the protocol handshake, implementations of the last standard aren't compatible with the new one. Aleph should (at least in a branch) implement the newer and more secure standard.
The text was updated successfully, but these errors were encountered: