Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid suggestions for into #83

Closed
sgt opened this issue Aug 1, 2013 · 1 comment
Closed

invalid suggestions for into #83

sgt opened this issue Aug 1, 2013 · 1 comment
Labels

Comments

@sgt
Copy link

sgt commented Aug 1, 2013

(into [] ...) is not always equivalent to (vec ...), for example when the argument must be used within a reducer (a common case with core.reducers functions). In these cases, "into" works since it uses reduce internally, whereas "vec" doesn't.

Maybe this rule should be deactivated by default.

@danielcompton
Copy link
Member

Adding comments to suggestions is being tracked in #107. This would let you explain the difference between into [] and vec when suggesting the change so people can understand when it's not appropriate to use vec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants