Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codox doesn't see protocol functions imported by Potemkin #25

Closed
Engelberg opened this issue Jul 20, 2014 · 4 comments
Closed

Codox doesn't see protocol functions imported by Potemkin #25

Engelberg opened this issue Jul 20, 2014 · 4 comments

Comments

@Engelberg
Copy link

I don't really know whether this is a codox issue or a potemkin issue. I'm raising it as an issue here, because my best guess is that the underlying issue is that something about the metadata attached to potemkin-imported protocol functions isn't quite right, so codox doesn't recognize it.

@ztellman
Copy link
Collaborator

The documentation for Lamina would suggest otherwise: http://ideolalia.com/lamina/lamina.core.html. Can you provide a failing case?

@Engelberg
Copy link
Author

OK, just emailed to you.

@Engelberg
Copy link
Author

Last July, I emailed you an example of vars imported via potemkin that aren't showing up in codox. Did you ever get a chance to look at that? Thanks.

@xsc
Copy link
Contributor

xsc commented Feb 7, 2015

[...] my best guess is that the underlying issue is that something about the metadata attached to potemkin-imported protocol functions isn't quite right. [...]

Actually, it's completely right. Codox has this feature where it groups protocol functions together with the corresponding protocol - but if the protocol cannot be found in the same namespace those functions just disappear.

So, IMO, it is not a potemkin issue (and I opened a PR that might fix the issue at codox).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants