Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.async false positive #27

Closed
seancorfield opened this issue Dec 3, 2022 · 3 comments
Closed

core.async false positive #27

seancorfield opened this issue Dec 3, 2022 · 3 comments

Comments

@seancorfield
Copy link
Contributor

See jeremylong/DependencyCheck#4384 (comment) for background.

I thought clj-watson wrapped that library and therefore false positive fixes there would automatically apply to clj-watson, but I see core.async flagged as a FP with the latest clj-watson so I'm wondering what the actual wrapping is and why FP fixes wouldn't apply?

I can (and have) easily applied a suppression locally for my clj-watson config but feel like I shouldn't need to?

@seancorfield
Copy link
Contributor Author

seancorfield commented Dec 4, 2022

I added org.owasp/dependency-check-core {:mvn/version "RELEASE"} to my :watson alias to override the version used -- which pulled 7.4.0 from Maven (not 7.3.2 which I was expecting) -- and that got rid of both FPs I had suppressions for.

Perhaps worth a new release with all the deps updated?

Or suggest in the README that folks should add that dependency to always get the latest version? ("RELEASE" is unsupported so maybe link to https://search.maven.org/artifact/org.owasp/dependency-check-core so folks can find the most recent version to use?).

@mthbernardes
Copy link
Contributor

Hi @seancorfield thx for the issue, sorry for the late answer, but I released a new version of clj-watson 😄

@seancorfield
Copy link
Contributor Author

Thanks. I'll update our build.clj at work to use that -- but I'll probably continue to override the o.owasp.d-c-c dep with "RELEASE" so that we continue to automatically get the very latest of that without needing clj-watson to be updated. At least until it breaks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants