Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook-generated (def ...) form doesn't seem recognized by project requiring sicmutils #1626

Closed
sritchie opened this issue Mar 22, 2022 · 3 comments
Labels
expired expired - might be closed due to too little activity
Projects

Comments

@sritchie
Copy link
Contributor

[ To keep development of this project going, consider sponsoring. If you are
already a sponsor, thank you! ]

version

[ Please specify which version of clj-kondo you're using. You can find this with clj-kondo --version.]

macro usage

yes!
platform

JVM, also native.

editor

emacs via cider.

problem

I’m hitting a problem where in a project that takes sicmutils as a dependency, any namespace that tries to use a form like new-sym defined in sicmutils.env with (import-def original-value new-sym) fails to recognize sicmutils.env/new-sym, EVEN THOUGH namespaces inside the project work fine.

@borkdude also noted that the principal-value var doesn't appear here:

cat .clj-kondo/.cache/v1/cljc/sicmutils.env.transit.json | jet --from transit --query ':clj keys' --pretty

repro

https://github.com/sritchie/kondo-repro

config

{:config-paths ["babashka/sci"
                "sicmutils/sicmutils"]}

expected behavior

I'd expect that var to resolve correctly, since its hook emits a proper def form, and this works inside the sicmutils project.

@borkdude borkdude added this to Needs triage in clj-kondo via automation Mar 24, 2022
@stale
Copy link

stale bot commented Mar 22, 2023

This issue has been automatically marked as expired because it has not had recent activity. To prevent it from being closed, please leave a message. Additionally, consider giving the original message a thumbs up if this issue is important to you, so it will appear higher in this list. Thank you for your contributions!

@stale stale bot added the expired expired - might be closed due to too little activity label Mar 22, 2023
@borkdude
Copy link
Member

@sritchie Sorry I dropped the ball on this. Is this still a problem?

@stale stale bot removed the expired expired - might be closed due to too little activity label Mar 22, 2023
Copy link

stale bot commented Mar 22, 2024

This issue has been automatically marked as expired because it has not had recent activity. To prevent it from being closed, please leave a message. Additionally, consider giving the original message a thumbs up if this issue is important to you, so it will appear higher in this list. Thank you for your contributions!

@stale stale bot added the expired expired - might be closed due to too little activity label Mar 22, 2024
@stale stale bot closed this as completed Apr 21, 2024
clj-kondo automation moved this from Needs triage to Done Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expired expired - might be closed due to too little activity
Projects
clj-kondo
  
Done
Development

No branches or pull requests

2 participants