Detect Reagent component function calls for arity linting

[borkdude]

(defn my-component []
  [:div "Hello"])

[:div [my-component 1 2 3]] ;; <- arity error

[borkdude]

How do we detect if a function is intended as a Reagent component and hence a "vector call" should be interpreted as a function call?

A combination of one or more of these:

1. we're in .cljs or a CLJS reader conditional part in .cljc
2. We could look at the namespace requires. If reagent.core occurs there, it's extremely likely
3. Check if a function uses r/create-class

Still, it's not 100% accurate to tell if [foo bar baz] is a Reagent component call or just a random vector with some symbols, so this will probably introduce a lot of false positives.

[agoldhammer]

In addition, using the idiomatic reagent [component.classname ...] or [component#id ...] produces "unresolved symbol" errors. Can this be fixed?

[borkdude]

@agoldhammer That's a separate issue. Can you please make an issue with a self-consistent example (.cljs file) that I can lint?

[borkdude]

@agoldhammer According to a Reagent maintainer on Clojurians slack (@Deraen) this is not supported.

[agoldhammer]

Sorry, my mistake. Supported in Hiccup, not Reagent. Please ignore.

[borkdude]

Thought about this long enough and I don't see a feasible way to do this without producing false positives.