Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require-python - (minor) - possibly inconsistent syntax #36

Closed
cnuernber opened this issue Dec 18, 2019 · 3 comments
Closed

require-python - (minor) - possibly inconsistent syntax #36

cnuernber opened this issue Dec 18, 2019 · 3 comments

Comments

@cnuernber
Copy link
Collaborator 

user> (require-python '(mxnet mxnet.module))
nil
user> (require-python '[mxnet mxnet.module])
Execution error (IllegalArgumentException) at libpython-clj.require/python-lib-configuration (require.clj:306).
Vector arg to map conj must be a pair
@jjtolton
Copy link
Contributor

jjtolton commented Dec 19, 2019 •
edited
Loading

Yeah I was just thinking about that today. I should probably core.spec that with some more helpful error messages. The spec should be 'ns or '(ns1 ns2) or (req1 [ns2 :as alias ~@etc] [ns ~@etc] ~@reqs)

@jjtolton
Copy link
Contributor

Proposed enhancement: add core.spec pre/post conditions

@cnuernber
Copy link
Collaborator Author

This seems fine to me and actually matches pretty closely what happens when I do a normal clojure require statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnuernber @jjtolton