Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datalevin fails to analyze #620

Closed
corasaurus-hex opened this issue Apr 29, 2022 · 8 comments
Closed

Datalevin fails to analyze #620

corasaurus-hex opened this issue Apr 29, 2022 · 8 comments

Comments

@corasaurus-hex
Copy link
Contributor

Womp womp! Datalevin fails to analyze. Seems like a pretty popular project and it'd be nice if we could get it working.

https://app.circleci.com/pipelines/github/cljdoc/builder/31218/workflows/2f4e0bdc-b511-4bc2-803c-849d3985c8ee/jobs/47592

@lread
Copy link
Member

lread commented Apr 29, 2022

Hiya @corasaurus-hex, do you know if Datalevin is Clojure only?
The Clojure analysis seems to pass.

Because Datalevin has .cljc files our analyzer is assuming it is also ClojureScript and the ClojureScript analysis fails.

@corasaurus-hex
Copy link
Contributor Author

It seems to have some code that supports cljs...

@corasaurus-hex
Copy link
Contributor Author

Hmmm... I can't find a cljs release anywhere.

@lread
Copy link
Member

lread commented May 6, 2022

But... it does generate its own API docs with codox, which seems to use the default platform analysis (Clojure only).
Note: It uses some codox options we do not currently support.

In the past, I've pinged lib authors to gage interest in getting their docs to build on cljdoc. An easy sell, I would think, with our new docset search feature!
After they are interested, I sometimes offer to do the PR for them.

@lread
Copy link
Member

lread commented May 6, 2022

I can reach out on Slack to Datalevin team if you like. Lemme know!

@lread
Copy link
Member

lread commented Aug 30, 2022

Reached out: juji-io/datalevin#139

@lread
Copy link
Member

lread commented Aug 30, 2022

Done! Next release of datalevin should look beautiful on cljdoc!

@lread lread closed this as completed Aug 30, 2022
@corasaurus-hex
Copy link
Contributor Author

🚀🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants