Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can renderer middleware be replaced with extension lifecycles? #13

Open
1 of 3 tasks
vlaaad opened this issue Apr 30, 2019 · 0 comments
Open
1 of 3 tasks

Can renderer middleware be replaced with extension lifecycles? #13

vlaaad opened this issue Apr 30, 2019 · 0 comments
Labels
idea Not an actual issue, a proposal

Comments

@vlaaad
Copy link
Contributor

vlaaad commented Apr 30, 2019 •
edited

It can benefit from caching done in lifecycles, currently renderer middleware is invoked on every call to renderer.

  • wrap-many middleware can be done as ext-many that has some coll of descriptions and produces vec of components
  • wrap-context-desc can both put context in opts and wrap :fx.opt/type->lifecycle
  • wrap-map-desc is the real reason middleware exists: to transform renderer input into desc, can it be done differently in backwards-compatible way?
@vlaaad vlaaad added the idea Not an actual issue, a proposal label Apr 30, 2019
@vlaaad vlaaad mentioned this issue Jul 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea Not an actual issue, a proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlaaad