Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkService #11

Open
clmct opened this issue Jan 17, 2022 · 0 comments
Open

NetworkService #11

clmct opened this issue Jan 17, 2022 · 0 comments

Comments

@clmct
Copy link
Owner

clmct commented Jan 17, 2022

class NetworkService {
    // MARK: Properties
    private let defaults: UserDefaultsManager
    
    private var isRetrying = false
    
    // MARK: Init
    init(defaultsManager: UserDefaultsManager) {
        defaults = defaultsManager
    }
}

// MARK: Interceptor
extension NetworkService: RequestInterceptor {
    func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
        var request = urlRequest
        guard let token = defaults.readAccessToken() else {
            completion(.success(urlRequest))
            return
        }
        
        request.setValue("Bearer \(token)", forHTTPHeaderField: RequestKeys.authorization)
        completion(.success(request))
    }
    
    func retry(_ request: Request, for session: Session, dueTo error: Error, completion: @escaping (RetryResult) -> Void) {
        guard request.retryCount < RetryPolicy.defaultRetryLimit else {
            completion(.doNotRetry)
            return
        }
        
        determineRetryAction(error, retrying: isRetrying, completion: completion)
    }
    
    private func determineRetryAction(_ error: Error, retrying: Bool, completion: @escaping (RetryResult) -> Void) {
        if retrying {
            completion(.retryWithDelay(2))
            return
        }
        
        if error.asAFError?.responseCode == 401 && !retrying {
            isRetrying = true
            requestRefresh { [weak self] isSuccess in
                isSuccess ? completion(.retryWithDelay(2)) : completion(.doNotRetry)
                self?.isRetrying = false
            }
        } else {
            completion(.doNotRetry)
        }
    }
}

// MARK: Auth
extension NetworkService {
    func signInRequest(email: String, password: String,
                       onSuccess success: @escaping () -> Void,
                       onFailure failure: @escaping (_ error: Error) -> Void) {
        AF.request(urlStrings.base + urlStrings.login,
                   method: .post,
                   parameters: [
                    RequestKeys.email: email,
                    RequestKeys.password: password
                   ],
                   encoding: JSONEncoding.default).validate().responseData { [weak self] response in
            switch response.result {
            case .success(let data):
                let decoder = JSONDecoder()
                if let token = try? decoder.decode(TokenResponse.self, from: data) {
                    self?.defaults.writeTokens(accessToken: token.accessToken,
                                               refreshToken: token.refreshToken)
                    success()
                } else {
                    failure(AuthError(code: 1002))
                }
            case .failure(let error):
                failure(AuthError(code: error.responseCode))
            }
        }
    }
...

Класс NetworkService слишком большой и содержит в себе все запросы, которые разделены логически на extensions. Большой класс считается плохим тонном (ссылка) Тяжело читать. Лучше вынести по файлам extensions. А назвать NetworkService+Auth и тд. Это облегчит читаемость и работу с кодом.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant