Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoder.js //TODO: add attributes #3

Open
Diferno opened this issue Sep 23, 2016 · 2 comments
Open

encoder.js //TODO: add attributes #3

Diferno opened this issue Sep 23, 2016 · 2 comments

Comments

@Diferno
Copy link
Contributor

Diferno commented Sep 23, 2016

Hi, first of all, congratulations for this exellent job!

Everything works as a charm until we have tags with attributes and values. I just found the //TODO around line 100 in the encoder.js file.

Are you working on this?

Thanks in advance

@clncln1
Copy link
Owner

clncln1 commented Sep 27, 2016

Hi, thanks for the feedback. I am not actively working on adding attribute support.
But a pull request is more than welcome :)

@Diferno
Copy link
Contributor Author

Diferno commented Sep 28, 2016

Hi, just created pull request for attributes, prefix and values support. It works on my side, hope it helps :)

I'll add the simple and extended codepages too that I used for QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants