Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1297): spacetime logs -f should not start at the very beginning #1298

Merged
merged 3 commits into from
May 28, 2024

Conversation

bfops
Copy link
Contributor

@bfops bfops commented May 24, 2024

Description of Changes

Fixes #1297.

API and ABI breaking changes

No

Expected complexity level and risk

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Ran spacetime call say_hello a bunch, then ran spacetime logs -f to see that it defaulted to 10 lines

@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels May 24, 2024
@bfops bfops requested a review from jdetter May 24, 2024 18:29
@bfops bfops enabled auto-merge May 24, 2024 19:33
@bfops bfops disabled auto-merge May 24, 2024 19:33
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks Zeke 👍

@bfops bfops enabled auto-merge May 28, 2024 00:27
@bfops bfops added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit 8096ab6 May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spacetime logs -f should not by default start from the beginning of the log
2 participants