Requires with lots of refers seems very slow when calling cljr-remove-unused-requires

[AeroNotix]

(ns payments.schema_test
  (:require [payments.utils :refer [uuid]]
            [payments.schemavalidation :refer [account-create
                                               order-schema
                                               credit-card-schema
                                               payment-base-schema
                                               payment-status-schema]]
            [clojure.test :refer :all]
            [closchema.core :refer [validate report-errors]]))

This seems very slow when calling cljr-remove-unused-requires.

[benedekfazekas]

hi Aero,

which version are you using? If 0.12.0 (latest released) can you please retest with master head?

[AeroNotix]

@benedekfazekas

xeno@xenocorp:~/.emacs.d% ls elpa/clj-refactor-20140330.651

So, from today?

[benedekfazekas]

hm... that seems to be the latest. Can't really reproduce tho. I added some mock fns but just to be sure can you share your whole namespace pls?

[AeroNotix]

That is the whole namespace.

[expez]

Is it slow when you only have that ns in the file? I would expect it to be quite slow with that ns followed by a ton of code (as quite a bit of searching is done).

[benedekfazekas]

when I run it it is practically instant. I get

(ns payments.schema_test
  (:require [clojure.test :refer :all]))

which makes sense.

[benedekfazekas]

@expez does it slow down in your environment as well with only the ns declaration in the file?

[AeroNotix]

@expez no, it's fast with just that ns in a file. The file is "only" 359 lines long.

[expez]

@benedekfazekas I suspect this only occurs when such an ns declaration precedes a few hundred lines of code. Which is why you cannot reproduce the problem.

Slowness in such a situation is to be expected, given how much searching is involved in this particular refactoring.

[AeroNotix]

Closing, then. If it's related to the number of forms there's not much that can be done (assuming the core search algo is efficient.)

[benedekfazekas]

@expez agreed. although there could be something funky in the actual file which the search (regexp) chokes on... I just want to rule this out.

so @AeroNotix any chance you can send/attach the whole file?

[AeroNotix]

@benedekfazekas Unfortunately, no, I can't really send the whole file. It's gonna be hard to anonymise it.

[expez]

@AeroNotix If cljr isn't already bytecompiled doing that might get you a ~2-5x speedup.

[AeroNotix]

@expez s I tend to avoid byte compilation, but it's certainly worth a try! Thanks.

[benedekfazekas]

good call @expez, thx ;)

also diff approach to clj source mentioned in #11 (eg build an AST) can change this land. but only wild guessing here...

[benedekfazekas]

there is a performance tweak now in the latest version if u use refactor-nrepl with it. search is done in an AST by clojure instead of the buffer by elisp. enjoy